------- Comment #22 from seongbae dot park at gmail dot com 2007-07-26 17:56 ------- Subject: Re: [4.3 regression]: gfortran.dg/auto_array_1.f90
On 7/26/07, Kenneth Zadeck <[EMAIL PROTECTED]> wrote: > Seongbae Park (???, ???) wrote: > > On 7/26/07, Kenneth Zadeck <[EMAIL PROTECTED]> wrote: > >> This patch extends the fix in > >> http://gcc.gnu.org/ml/gcc-patches/2007-06/msg01557.html > >> to handle the case of clobbers inside conditional calls. > >> > >> This problem caused the regression of gfortran.dg/matmul_3.f90 on the > >> ia-64 in addition to the regression cited in this pr. > >> > >> Tested on ppc-32, ia-64 and x86-64. > >> > >> 2007-07-26 Kenneth Zadeck <[EMAIL PROTECTED]> > >> > >> PR middle-end/32749 > >> > >> * df-problems.c (df_note_bb_compute): Handle case of clobber > >> inside conditional call. > >> > >> ok to commit? > > > > This change is OK. > > Though I wonder if we need to do similar checking > > for the regular insn case below. > No the checking is done in df_create_unused_note. The only reason you > have to do it here is that you are not calling that. > > thanks Now that I look at df_create_unused_note, this patch smells a bit - because the condition inside the for loop looks identical to df_create_unused_node. I think it would be cleaner if we split the live vector update into a separate function. i.e. attached patch (untested). ------- Comment #23 from seongbae dot park at gmail dot com 2007-07-26 17:56 ------- Created an attachment (id=13986) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=13986&action=view) -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32749
