------- Comment #10 from hubicka at ucw dot cz 2008-03-03 00:50 ------- Subject: Re: [4.4 Regression]: FAIL: abi_check
> Confirmed, of course. Honza, any news on the inlining issue? Sorry, I looked into it, got confused and then distracted by other problem and forgot to return back. At second look, the function is estimated to make code to grow slightly after being inlined. The functions is still getting inlined by default, however there are code paths are marked by __builtin_expect as unlikely. The call sites on these paths are considered cold and thus function is not inlined there to optimize for size. This seems very sane behaviour at first sight. However the catch is that the function is bit bigger than call sequence but still after being fully inlined, the overall code size is estimated to shrink because offline body is eliminated. So it is definitly better to inline and have more options for optimizing. Quite corner case but easy enough to handle. I am testing patch to take this fact into account and lets see if it solves to failure too. It gets function in question inlined, but makes other not inlined this time ;) Honza -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=35262
