------- Comment #22 from burnus at gcc dot gnu dot org  2008-04-06 16:22 -------
> Created an attachment (id=15435)
 --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=15435&action=view) [edit]
> Handles bounds checking and fixes regressions.

Great.

> However, I'm not quite sure about some things I did [...]

I think your patch is in a good enough shape to post it to [EMAIL PROTECTED]
and ask there for comments; this ensures that all gfortraners read it (and not
only three Fortraners) and it makes discussing easier than a in a bugreport.

I think one could also submit it for review, which means that you need to write
a changelog and should CC the email to [EMAIL PROTECTED]  (The reason is that 
then
also developers of the middle end can glance at it and give comments.)

+/* XXX: Ok as global or does bounds-checking need to be reentrant for things
+   like nested constructors?  */

I think it is OK for now, but we need to fix it later. I found a test case
which crashes gfortran (ICE, internal compiler error) for nested character
constructors - even without typespec or bounds checks. See PR 35846. I think
this should be fixed together with the rest.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=27997

Reply via email to