------- Comment #1 from manu at gcc dot gnu dot org  2008-10-28 15:41 -------
Jason, what you think about this?

In any case, there are some issues with this code:

First, it would be better to print the type of the expression (%qT) rather than
the expression itself (%qE), because it is informative and in many cases we
cannot reconstruct the expression in any sensible way.

Also, that function could share a lot of code with conversion_warning in
c-common.c.

Finally, it is missing a proper comment above it.


-- 

manu at gcc dot gnu dot org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jason at redhat dot com,
                   |                            |manu at gcc dot gnu dot org


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=37932

Reply via email to