------- Comment #1 from joseph at codesourcery dot com 2009-10-06 00:10 ------- Subject: Re: New: Bad .comm directive
On Mon, 5 Oct 2009, danglin at gcc dot gnu dot org wrote: > The directive is: > > .comm gnu_lto_v1,1,1 > > This apparently comes from here: > > /* Emit LTO marker if LTO info has been previously emitted. This is > used by collect2 to determine whether an object file contains IL. > We used to emit an undefined reference here, but this produces > link errors if an object file with IL is stored into a shared > library without invoking lto1. */ > if (flag_generate_lto) > fprintf (asm_out_file,"\t.comm\tgnu_lto_v1,1,1\n"); I pointed out in my review that this was inappropriate, both because of the hardcoding of .comm syntax and because the name is in the user namespace. The LTO people need to reread my comments (on all the patches, not just this one) and look for any others that have not been addressed or had PRs filed. http://gcc.gnu.org/ml/gcc-patches/2009-09/msg02139.html has these particular comments. -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41597
