http://gcc.gnu.org/bugzilla/show_bug.cgi?id=46916
--- Comment #90 from Iain Sandoe <iains at gcc dot gnu.org> 2010-12-17 14:21:00
UTC ---
(In reply to comment #89)
> (In reply to comment #88)
> > Iain,
> > Do you think the "no debug symbols" warnings in the partition2.C test
> > case
> > on darwin10 are the caused by the same issue (lack of pub symbols) as those
> > additional instances caused by honza'a patch? Also, do we see any additional
> > failures beyond those warnings when honza'a patch is added onto this current
> > darwin patch?
>
> I think you should analyse comment #42. If I did not do any mistake, the
> partition2.C test is unsupported with current trunk, but becomes supported
> with
> any of the patches in this PR. If this is correct, it means that these patches
> change something in the testsuite machinery (e.g., a failing test becomes
> successful).
well, this change is the likely difference:
+ if (opts->x_flag_reorder_blocks_and_partition
+ && !opts_set->x_flag_reorder_functions)
+ opts->x_flag_reorder_functions = 1;
as far as whether Darwin10 supports -freorder-blocks-and-partition
- there should be no difference before/after the patch (darwin < 10 should not
support at present).
It would be interesting to know why the test claims to be 'unsupported' for
current trunk (except that it would fail because of this bug).
// { dg-require-effective-target freorder }
// { dg-options "-fnon-call-exceptions -freorder-blocks-and-partition" }
you would have to back out of the patches and the change that causes the fault
.. if the test still claims to be unsupported - that implies something
different (again, not related to the current bug).
In any event the two remaining issues need resolution -- I suspect they are
causing fallout elsewhere.
... I just don't see the point in swelling this patch to solve those ..
the intention of this patch is to get correct function section selection for
Darwin.
