[Bug middle-end/56288] New: always true conditional expression in verify_ssa_name

[pageexec at freemail dot hu]

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=56288



             Bug #: 56288

           Summary: always true conditional expression in verify_ssa_name

    Classification: Unclassified

           Product: gcc

           Version: 4.8.0

            Status: UNCONFIRMED

          Severity: normal

          Priority: P3

         Component: middle-end

        AssignedTo: unassig...@gcc.gnu.org

        ReportedBy: pagee...@freemail.hu





git commit ec11736b57986660deef21d6375d2f23edf290d2 introduced

SSA_NAME_IDENTIFIER in addition to SSA_NAME_VAR where the latter can now return

NULL_TREE. so far so good, all users have been adjusted for this new condition

except there is i think a mistake in gcc/tree-ssa.c:verify_ssa_name that had

this change:



-  if (TREE_TYPE (ssa_name) != TREE_TYPE (SSA_NAME_VAR (ssa_name)))

+  if (SSA_NAME_VAR (ssa_name) != NULL_TREE

+      && TREE_TYPE (ssa_name) != TREE_TYPE (ssa_name))



i think the intention was more like preserving the original check for TREE_TYPE

(ssa_name) != TREE_TYPE (SSA_NAME_VAR (ssa_name)) instead.