http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55189

--- Comment #10 from Sylvestre Ledru <sylvestre at debian dot org> ---
(In reply to Manuel López-Ibáñez from comment #9)
> 
> Cool! Hopefully it goes quickly. After that, I would suggest that you submit
> the patch to gcc-patches and CC Jason Merrill and Dodji Seketeli, either of
> them should be able to approve this.
Sure. Thanks for the suggestion.

> I noticed that your patch does not update doc/invoke.texi to reflect the
> fact that -Wreturn-type is enabled by default instead of by -Wall (it would
> be great to automatically generate some parts of the manual from the options
> description).
I will have a look!

> I also noticed that you did not include -Wmissing-return in your patch as
> discussed here: http://gcc.gnu.org/ml/gcc/2013-11/msg00288.html
>  
> (Perhaps you did, and I am using github incorrectly?)
I did... removed it :)
I've followed Jason suggestion here:
http://gcc.gnu.org/ml/gcc-patches/2014-01/msg01033.html
The problem that we were trying to address with -Wmissing-return has been fixed
(AFAIK) by the commit description in comment #7

> I think you will get easier approval if you include it (or send two patches
> in the same email) and point out to the previous discussion (in particular
> Dodji, Joseph and Jason's approval of this idea).
Sure. Thanks for the advice.

Reply via email to