https://gcc.gnu.org/bugzilla/show_bug.cgi?id=60732

--- Comment #8 from Brooks Moses <brooks at gcc dot gnu.org> ---
Yup, that's essentially exactly what I had in mind, with a couple of minor
adjustments:

* I'd use your original patch of -fabi-version=0 to altivec-7.C, so that we're
continuing to test the latest ABI version even if it gets updated again in the
future.

* I'd make -fabi-version=2 on altivec-7a.C unconditional, rather than
conditional on Darwin.  The reason that we got into this in the first place is
that I was building with a default of -fabi-version=4, and that test won't pass
on Linux in that case because at abi=4 only the new symbols are emitted.

* It's probably worth adding some comments to explain why these settings are
here.  I'd suggest:

On altivec-7.C: "On Linux, these symbols are emitted on all abi versions. 
However, on Darwin, they are only emitted on abi verson 4 and later."

On altivec-7a.C: "These symbols are only emitted for abi version 3 and
earlier."

In any case, thank you very much for following up on this.  I had meant to, but
obviously hadn't made the time to get around to it, so I really appreciate you
doing this for me!

Reply via email to