https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69237
Franz Sirl <sirl at gcc dot gnu.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sirl at gcc dot gnu.org --- Comment #2 from Franz Sirl <sirl at gcc dot gnu.org> --- Or the '--fcount;'. Does the warning go away if you add braces like that: void pop(T* elem) { SkASSERT(fCount > 0); if (elem) { *elem = (*this)[fCount - 1]; } --fCount; } Or add the closing brace after the '--fCount;' in case that's the correct code behaviour. I believe the warning is justified here.