https://gcc.gnu.org/bugzilla/show_bug.cgi?id=69276

--- Comment #3 from Martin Liška <marxin at gcc dot gnu.org> ---
(In reply to Jakub Jelinek from comment #2)
> Comment on attachment 37341 [details]
> suggested patch
> 
> +  else if (is_gimple_call (stmt) && gimple_store_p (stmt)
> +        && gimple_clobber_p (stmt))
> +    {
> +      asan_mem_ref r;
> +      asan_mem_ref_init (&r, NULL, 1);
> +
> +      r.start = gimple_call_lhs (stmt);
> +      r.access_size = int_size_in_bytes (TREE_TYPE (r.start));
> +      return has_mem_ref_been_instrumented (&r);
> +    }
> +
> 
> This condition is never true, did you mean !gimple_clobber_p instead?
> But obviously calls are never clobbers, so there is no need to test that.

Sure, that was a typo, yeah it can be removed from the condition ;)

Reply via email to