[Bug other/77421] Bugs found in GCC with the help of PVS-Studio

[rguenth at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=77421

--- Comment #11 from Richard Biener <rguenth at gcc dot gnu.org> ---
(In reply to Jonathan Wakely from comment #5)
> Remaining issues:
> 
> find_structure in gengtype.c does:
> 
>   structures = s;
>   s->kind = kind;
>   s->u.s.tag = name;
>   structures = s;
> 
> The first assignment is redundant.
> 
> ix86_expand_args_builtin in gcc/config/i386/i386.c does:
> 
>     case V8DI_FTYPE_V8DI_V8DI_V8DI_INT_UQI:
>     case V16SI_FTYPE_V16SI_V16SI_V16SI_INT_UHI:
>     case V2DF_FTYPE_V2DF_V2DF_V2DI_INT_UQI:
>     case V4SF_FTYPE_V4SF_V4SF_V4SI_INT_UQI:
>     case V8SF_FTYPE_V8SF_V8SF_V8SI_INT_UQI:
>     case V8SI_FTYPE_V8SI_V8SI_V8SI_INT_UQI:
>     case V4DF_FTYPE_V4DF_V4DF_V4DI_INT_UQI:
>     case V4DI_FTYPE_V4DI_V4DI_V4DI_INT_UQI:
>     case V4SI_FTYPE_V4SI_V4SI_V4SI_INT_UQI:
>     case V2DI_FTYPE_V2DI_V2DI_V2DI_INT_UQI:
>        nargs = 5;
>       nargs = 5;
> 
> The first one is redundant, and wrongly indented.
> 
> cand_value_at in tree-ssa-loop-ivopts.c does:
> 
>   tree type = TREE_TYPE (iv->base);
>   tree steptype = type;
>   if (POINTER_TYPE_P (type))
>     steptype = sizetype;
>   steptype = unsigned_type_for (type);
> 
> It's unclear why the last four lines aren't just:
> 
>   tree steptype = unsigned_type_for (type);

it should be

  if (POINTER_TYPE_P (type))
    steptype = sizetype
  else
    steptype = unsigned_type_for (type);