https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88188

--- Comment #4 from Jakub Jelinek <jakub at gcc dot gnu.org> ---
(In reply to Christophe Lyon from comment #3)
> (In reply to Jakub Jelinek from comment #2)
> >     trunk/gcc/testsuite/gcc.dg/tree-ssa/phi-opt-11.c
> 
> Is this part of the commit intended?
> 
> It's not mentioned in the ChangeLog, and I see a regression:
> FAIL: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times optimized "if" 0
> (used to have PASS: gcc.dg/tree-ssa/phi-opt-11.c scan-tree-dump-times
> optimized "if" 2)
> 
> on arm-none-eabi --with-mode thumb --with-cpu cortex-m3

It was intended, but not as part of this commit, sorry for the screw-up.
It was meant as the PR85368 fix.
I've tested it on x86_64 as example of !logical_op_short_circuit && branch_cost
target, Jeff/Andreas on s390x as example of logical_op_short_circuit &&
branch_cost target and I've tested on powerpc64{,le} as example of
logical_op_short_circuit && !branch_cost target.
arm is a branch_cost target and cortex-m3 is logical_op_short_circuit, why
doesn't the -mbranch-cost=2 option override the cortex-m3 defaults?
Anyway, can you follow-up in PR85368 instead of here, in order not to clutter
this PR?

Reply via email to