[Bug go/89199] libgo regression in implementation of CompareAndSwap functions resulting in intermittent testcase failures on ppc64le power9 after r268458

Wed, 06 Feb 2019 12:47:04 -0800 

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89199

--- Comment #2 from ian at gcc dot gnu.org <ian at gcc dot gnu.org> ---
Author: ian
Date: Wed Feb  6 20:46:00 2019
New Revision: 268591

URL: https://gcc.gnu.org/viewcvs?rev=268591&root=gcc&view=rev
Log:
        PR go/89199
    sync/atomic: use strong form of atomic_compare_exchange_n

    In the recent change to use atomic_compare_exchange_n I thought we
    could use the weak form, which can spuriously fail. But that is not
    how it is implemented in the gc library, and it is not what the rest
    of the library expects.

    Thanks to Lynn Boger for identifying the problem.

    Fixes https://gcc.gnu.org/PR89199

    Reviewed-on: https://go-review.googlesource.com/c/161359

Modified:
    trunk/gcc/go/gofrontend/MERGE
    trunk/libgo/go/sync/atomic/atomic.c

Reply via email to