https://gcc.gnu.org/bugzilla/show_bug.cgi?id=89447
--- Comment #7 from ro at CeBiTec dot Uni-Bielefeld.DE <ro at CeBiTec dot
Uni-Bielefeld.DE> ---
> --- Comment #6 from Ian Lance Taylor <ian at airs dot com> ---
> I've committed a version of your patch, which I hope will fix all the
> problems.
> Please let me know if not.
I've just bootstrapped with your patch on i386-pc-solaris2.11 and
sparc-sun-solaris2.11: no regressions. Besides, I've checked for calls
to libc functions with largefile equivalent in libgo: on i386 there's
only ftruncate and mkstemp (from libffi), here and on sparc there's also
mmap, as mentioned in the PR. Given that they use the non-largefile
types, those should be fine.
> One change to your patch in particular was that we shouldn't need a C version
> of __go_openat64. It should suffice to use just __go_openat, since the C code
> should call the right function anyhow. The bug was that
> libgo/go/internal/syscall/unix/at.go was referring to openat when it should
> have been referring to __go_openat.
I hadn't thought that fully through indeed; that's why I just attached my
preliminary patch to the PR instead of just submitting it to gcc-patches.
Thanks for fixing things up.
Rainer
