https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56879
Eric Gallager <egallager at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|UNCONFIRMED |RESOLVED
Resolution|--- |WORKSFORME
--- Comment #3 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to alex from comment #2)
> (In reply to comment #1)
> > Comment on attachment 29827 [details]
> > test source code and compiler output
> >
> > The solution is simple: don't use -Weffc++, it's deeply flawed. Using it
> > with
> > -Werror is just ridiculous. It's much better to use
> > -Wdelete-non-virtual-dtor
> > than -Weffc++
>
> It is not what we've been using it for (-Wdelete-non-virtual-dtor seems to
> be enabled by -Wall already). We'd like to keep other warnings that -Weffc++
> generates: it worked nicely for us until this point.
>
> > There are lots of known issues with -Weffc++ and noone has been motivated to
> > fix them, see e.g. PR 22395 comment 5 and PR 16166 comment 3 for some
> > discussion related to this warning.
>
> Too bad. This one could probably be a one-liner to just disable this warning
> since -Wnon-virtual-dtor is already enabled with -Weffc++ (and it does a
> better job). But "noone has been motivated" says it all. Anyway, thanks for
> the pointers.
I went to try to find where the warning came from, but it turns out that g++ no
longer warns on the testcase (at least for me)? I guess it might have been
fixed at some point, but since I don't feel like bisecting I'll just say
WORKSFORME
