https://gcc.gnu.org/bugzilla/show_bug.cgi?id=99212

--- Comment #15 from CVS Commits <cvs-commit at gcc dot gnu.org> ---
The master branch has been updated by David Malcolm <dmalc...@gcc.gnu.org>:

https://gcc.gnu.org/g:d3b1ef7a83c0c0cd5b20a1dd1714b868f3d2b442

commit r12-1303-gd3b1ef7a83c0c0cd5b20a1dd1714b868f3d2b442
Author: David Malcolm <dmalc...@redhat.com>
Date:   Tue Jun 8 14:45:57 2021 -0400

    analyzer: bitfield fixes [PR99212]

    This patch verifies the previous fix for bitfield sizes by implementing
    enough support for bitfields in the analyzer to get the test cases to pass.

    The patch implements support in the analyzer for reading from a
    BIT_FIELD_REF, and support for folding BIT_AND_EXPR of a mask, to handle
    the cases generated in tests.

    The existing bitfields tests in data-model-1.c turned out to rely on
    undefined behavior, in that they were assigning values to a signed
    bitfield that were outside of the valid range of values.  I believe that
    that's why we were seeing target-specific differences in the test
    results (PR analyzer/99212).  The patch updates the test to remove the
    undefined behaviors.

    gcc/analyzer/ChangeLog:
            PR analyzer/99212
            * region-model-manager.cc
            (region_model_manager::maybe_fold_binop): Add support for folding
            BIT_AND_EXPR of compound_svalue and a mask constant.
            * region-model.cc (region_model::get_rvalue_1): Implement
            BIT_FIELD_REF in terms of...
            (region_model::get_rvalue_for_bits): New function.
            * region-model.h (region_model::get_rvalue_for_bits): New decl.
            * store.cc (bit_range::from_mask): New function.
            (selftest::test_bit_range_intersects_p): New selftest.
            (selftest::assert_bit_range_from_mask_eq): New.
            (ASSERT_BIT_RANGE_FROM_MASK_EQ): New macro.
            (selftest::assert_no_bit_range_from_mask_eq): New.
            (ASSERT_NO_BIT_RANGE_FROM_MASK): New macro.
            (selftest::test_bit_range_from_mask): New selftest.
            (selftest::analyzer_store_cc_tests): Call the new selftests.
            * store.h (bit_range::intersects_p): New.
            (bit_range::from_mask): New decl.
            (concrete_binding::get_bit_range): New accessor.
            (store_manager::get_concrete_binding): New overload taking
            const bit_range &.

    gcc/testsuite/ChangeLog:
            PR analyzer/99212
            * gcc.dg/analyzer/bitfields-1.c: New test.
            * gcc.dg/analyzer/data-model-1.c (struct sbits): Make bitfields
            explicitly signed.
            (test_44): Update test values assigned to the bits to ones that
            fit in the range of the bitfield type.  Remove xfails.
            (test_45): Remove xfails.

    Signed-off-by: David Malcolm <dmalc...@redhat.com>

Reply via email to