https://gcc.gnu.org/bugzilla/show_bug.cgi?id=102285

Eric Gallager <egallager at gcc dot gnu.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ebotcazou at gcc dot gnu.org,
                   |                            |egallager at gcc dot gnu.org,
                   |                            |rguenth at gcc dot gnu.org,
                   |                            |vries at gcc dot gnu.org
           See Also|                            |https://gcc.gnu.org/bugzill
                   |                            |a/show_bug.cgi?id=82421

--- Comment #14 from Eric Gallager <egallager at gcc dot gnu.org> ---
(In reply to David Binderman from comment #11)
> (In reply to qinzhao from comment #10)
> 
> > 2734         /* The heuristic of fold_builtin_alloca_with_align differs
> 
> git blame says:
> 
> 
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2732)        
> /* The heuristic of fold_builtin_alloca_with_align differs before and
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2733)      
> after inlining, so we don't require the arg to be changed into a
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2734)      
> constant for folding, but just to be constant.  */
> 9e878cf1bae7 (Eric Botcazou          2017-10-19 15:58:05 +0000 2735)        
> if (gimple_call_builtin_p (stmt, BUILT_IN_ALLOCA_WITH_ALIGN)
> 9e878cf1bae7 (Eric Botcazou          2017-10-19 15:58:05 +0000 2736)       
> || gimple_call_builtin_p (stmt, BUILT_IN_ALLOCA_WITH_ALIGN_AND_MAX))
> 1fed1006552c (Tom de Vries           2011-08-31 07:04:25 +0000 2737)        
> {
> 13e49da934e9 (Tom de Vries           2011-10-07 12:49:49 +0000 2738)        
> tree new_rhs = fold_builtin_alloca_with_align (stmt);
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2739)        
> if (new_rhs)
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2740)        
> {
> 52a5515ed661 (Richard Biener         2021-04-14 13:40:58 +0200 2741)       
> gimplify_and_update_call_from_tree (gsi, new_rhs);
> 2f31f742a693 (Tom de Vries           2011-12-17 11:39:43 +0000 2742)       
> tree var = TREE_OPERAND (TREE_OPERAND (new_rhs, 0),0);
> 2f31f742a693 (Tom de Vries           2011-12-17 11:39:43 +0000 2743)       
> insert_clobbers_for_var (*gsi, var);
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2744)       
> return true;
> 5d882cc1dafe (Richard Guenther       2011-09-02 11:53:55 +0000 2745)        
> }
> 1fed1006552c (Tom de Vries           2011-08-31 07:04:25 +0000 2746)        
> }
> 
> so at least Tom, Eric and Richard have been in there.

cc-ing them

Reply via email to