https://gcc.gnu.org/bugzilla/show_bug.cgi?id=104531
--- Comment #3 from CVS Commits <cvs-commit at gcc dot gnu.org> --- The master branch has been updated by Jakub Jelinek <ja...@gcc.gnu.org>: https://gcc.gnu.org/g:023327643969d5469902a9ecfa6738a315f9e362 commit r12-7257-g023327643969d5469902a9ecfa6738a315f9e362 Author: Jakub Jelinek <ja...@redhat.com> Date: Wed Feb 16 09:27:11 2022 +0100 openmp: For min/max omp atomic compare forms verify arg types with build_binary_op [PR104531] The MIN_EXPR/MAX_EXPR handling in *build_binary_op is minimal (especially for C FE), because min/max aren't expressions the languages contain directly. I'm using those for the #pragma omp atomic x = x < y ? y : x; forms, but e.g. for the attached testcase we normally reject _Complex int vs. int comparisons, in C++ due to MIN/MAX_EXPR we were diagnosing it as invalid types for <unknown> while in C we accept it and ICEd later on. The following patch will try build_binary_op with LT_EXPR on the operands first to get needed diagnostics and fail if it returns error_mark_node. 2022-02-16 Jakub Jelinek <ja...@redhat.com> PR c/104531 * c-omp.cc (c_finish_omp_atomic): For MIN_EXPR/MAX_EXPR, try first build_binary_op with LT_EXPR and only if that doesn't return error_mark_node call build_modify_expr. * c-c++-common/gomp/atomic-31.c: New test.
