https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85487

--- Comment #13 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to rsand...@gcc.gnu.org from comment #12)
> Jeff said at the end of the thread that he wouldn't mind
> if someone else approves it, so it's probably worth posting
> again.

OK, will do.

I think Jeff's desire for a framework to ignore arbitrary pragmas might be
nice, but nobody's going to do that, and this small improvement has a working
patch. We shouldn't let the perfect be the enemy of the good.

> The patch LGTM FWIW: only (very) minor comment is that
> the unused argument name in handle_pragma_region can be dropped.

Yeah, that was consistent with the rest of the file, but I already changed the
rest in r12-7282-g73a118c209fcbb so I'd update my patch in the same way.

I'll also update it to ignore the very similar Xcode pragmas described in PR
61593.

> I think the patch would need to wait for GCC 13 now though.

Indeed.

Reply via email to