https://gcc.gnu.org/bugzilla/show_bug.cgi?id=110531

--- Comment #3 from Kewen Lin <linkw at gcc dot gnu.org> ---
(In reply to Hao Liu from comment #2)
> > Is the warning from some static analyzer?
> 
> No. I just find it maybe a bug while looking at the code.
> 
> > slp should be true always (always do analyze slp), it doesn't care what's 
> > in slp_done_for_suggested_uf.
> 
> Oh, I see. This is not a real bug.
> 
> 
> IMHO, it would be better to initialize it as "false", which should be much
> easier for someone to understand the code.

IMHO, the initialization with false is unnecessary and very likely it isn't
able to get optimized, it seems worse from this point of view. I was also
taught previously that useless initialization isn't recommended as sometimes it
can cover problems. But for the readability maybe one comment with more
explanation is worthy and better.

Reply via email to