https://gcc.gnu.org/bugzilla/show_bug.cgi?id=128651
--- Comment #3 from Richard Biener <rguenth at gcc dot gnu.org> ---
/* As all "inserted" statements are singleton SCCs, insert
to the valid table. This is strictly needed to
avoid re-generating new value SSA_NAMEs for the same
expression during SCC iteration over and over (the
optimistic table gets cleared after each iteration).
We do not need to insert into the optimistic table, as
lookups there will fall back to the valid table. */
so basically the comment is from the old implementation times where we iterated
SSA SCCs. I'm not sure it was accurate there but now we definitely can leak
value leaders of an optimistic iteration into the inserted expression which
would require unwinding.