On Thu, Mar 17, 2011 at 3:53 PM, Jeff Law <l...@redhat.com> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > On 03/17/11 08:48, Richard Guenther wrote: >> >> The gimple_uids are not initialized here, you need to make sure to >> call renumber_gimple_stmt_uids () before starting. Note that phiopt >> incrementally changes the IL, so I'm not sure those uids will stay >> valid as stmts are moved across blocks. > BTW, it's probably worth noting that renumber_gimple_stmt_uids doesn't > assign UIDs for PHI nodes. Worse yet, someone might have called > renumber_gimple_stmt_uids_in_blocks which *does* assign UIDs to PHIs. > The net result is you can have a PHI with a UID that conflicts with a > statement's UID or a PHI with no UID. > > It may not matter for this code, but having been recently bitten by > this, I thought I'd mention it.
Yep ;) It's worth fixing this inconsistency btw. Richard. > > > jeff > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.11 (GNU/Linux) > Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ > > iQEcBAEBAgAGBQJNgiBoAAoJEBRtltQi2kC7dLMH+QEhaTqTxoqDnOeMFTb0OLLi > 31BT3yDcSD0gEkFCZQB5qWo7RBBaepnRMtDpOxmGKcY8VlCvWdRDz6aFLlzDphzC > XWD/M4i01Of0tjIlCJqDVsUZklD2dvPOz0pwQpX5fteoGNedNGp5Xwq72Wq5YRKW > IcgpsRN/xbFA4HDk8ZfW5dkb+eQQptGHz5zj9KUz0pQbjqGS6e0oFIHCygwVW7u/ > zhGuD16OhtNS6Z5gkVs9j1POZOSAb7GawB0p5W0lJigzqRfLPIYLuOjtgZrLdgXQ > 3oK6uMX4WwZJK3PBT7Lo8MNTTnxjJZc4iL0SLArtd+U11QnxnsSIqKX9FBtX25A= > =d7Vy > -----END PGP SIGNATURE----- >
