On Mon, Mar 21, 2011 at 05:52:52PM +0100, Benjamin Kosnik wrote:
> > The problem is that abicheck only flags as incompatible additions to
> > GLIBCXX_3.4, but not other base versions. Ideally it would flag addition
> > to any version that hasn't been added (addition of the version is flagged
> > by
> > OBJECT:0:CXXABI_1.3.5
> > etc. entries (no @s in it).
> > This patch for now just complains about additions to any base versions,
> > I'll leave the better alternative to you ;)
>
> Yes, this seems like an improvement, thanks. I see that I already have
> a note in testsuite_abi.cc about stricter version checking.
Well, such stricter checking wouldn't be completely painless, e.g. currently
both current baseline_symbols.txt and the ones I've posted don't include the
two TLS: lines, because of the fear that not everyone has TLS enabled.
If baseline_symbols.txt right now miss some symbols, it is not a big deal
if it is not in the base version (with my patch base versions), but with
stricter checking it would complain. Either we'd just say that TLS is
assumed on these targets and add the TLS: lines, or we'd need to invent
some symbol conditionalizing or something.
Jakub
