On 03/24/2011 06:06 PM, Kai Tietz wrote:
+/* Compare two attributes for identity.  Return true if the attributes
+   are known to be equal; otherwise return false.  */
+
+static bool
+attribute_equal (const_tree attr1, const_tree attr2)
+{
+  if (attr1 == attr2)
+    return true;
+

Shouldn't this compare the TREE_VALUEs?

This function is also assuming that the TREE_PURPOSEs name the same attribute. I had figured that we would pull out the TREE_VALUE in the caller, but doing it in here is fine too as long as the function is documented as making that assumption.

Jason

Reply via email to