The guality tests are failing/passing intermittently. This confuses our builders which expect 0 failures and 0 xpasses. When they "work", it's not that they are working but dejagnu failed to launch gdb:
----------------------------------------------------------------------------- spawn [open ...] gdb: took too long to attach testcase [...]/gcc/testsuite/gcc.dg/guality/guality.exp completed in 17 seconds ----------------------------------------------------------------------------- And when they do execute, they show a bunch of XPASS results: ----------------------------------------------------------------------------- XPASS: gcc.dg/guality/example.c -O0 execution test XPASS: gcc.dg/guality/example.c -O1 execution test XPASS: gcc.dg/guality/example.c -O2 execution test XPASS: gcc.dg/guality/example.c -Os execution test XPASS: gcc.dg/guality/example.c -O2 -flto -flto-partition=none execution test XPASS: gcc.dg/guality/example.c -O2 -flto execution test XPASS: gcc.dg/guality/guality.c -O0 execution test XPASS: gcc.dg/guality/guality.c -O1 execution test XPASS: gcc.dg/guality/guality.c -O2 execution test XPASS: gcc.dg/guality/guality.c -O3 -fomit-frame-pointer execution test XPASS: gcc.dg/guality/guality.c -O3 -g execution test XPASS: gcc.dg/guality/guality.c -Os execution test XPASS: gcc.dg/guality/guality.c -O2 -flto -flto-partition=none execution test XPASS: gcc.dg/guality/guality.c -O2 -flto execution test XPASS: gcc.dg/guality/inline-params.c -O2 execution test XPASS: gcc.dg/guality/inline-params.c -O3 -fomit-frame-pointer execution test XPASS: gcc.dg/guality/inline-params.c -O3 -g execution test XPASS: gcc.dg/guality/inline-params.c -Os execution test XPASS: gcc.dg/guality/pr41353-1.c -O0 line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O1 line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O2 line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O3 -fomit-frame-pointer line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O3 -g line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -Os line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O2 -flto -flto-partition=none line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41353-1.c -O2 -flto line 28 j == 28 + 37 XPASS: gcc.dg/guality/pr41447-1.c -O0 execution test XPASS: gcc.dg/guality/pr41447-1.c -O1 execution test XPASS: gcc.dg/guality/pr41447-1.c -O2 execution test XPASS: gcc.dg/guality/pr41447-1.c -O3 -fomit-frame-pointer execution test XPASS: gcc.dg/guality/pr41447-1.c -O3 -g execution test XPASS: gcc.dg/guality/pr41447-1.c -Os execution test XPASS: gcc.dg/guality/pr41616-1.c -O0 execution test XPASS: gcc.dg/guality/pr41616-1.c -O1 execution test XPASS: gcc.dg/guality/pr41616-1.c -O2 execution test XPASS: gcc.dg/guality/pr41616-1.c -O3 -fomit-frame-pointer execution test XPASS: gcc.dg/guality/pr41616-1.c -O3 -g execution test XPASS: gcc.dg/guality/pr41616-1.c -Os execution test XPASS: gcc.dg/guality/sra-1.c -O0 line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O1 line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O2 line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O3 -fomit-frame-pointer line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O3 -g line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -Os line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O2 -flto -flto-partition=none line 43 a.j == 14 XPASS: gcc.dg/guality/sra-1.c -O2 -flto line 43 a.j == 14 ----------------------------------------------------------------------------- Perhaps it's just a matter of removing the XFAILs, but I have seen spurious FAILs in the past and I'm not sure why they are passing if they were meant to fail. Alex, are the above tests supposed to fail or not? This is on x86_64 with dejagnu combinations unix/-m32 and unix/-m64. For now, I am disabling these tests in the google branches. Tested on x86_64. Committed to google/integration. Will merge into the other google branches as well. 2011-03-30 Diego Novillo <dnovi...@google.com> * g++.dg/guality/guality.exp: Disable. * gcc.dg/guality/guality.exp: Disable. * gfortran.dg/guality/guality.exp: Disable. diff --git a/gcc/testsuite/g++.dg/guality/guality.exp b/gcc/testsuite/g++.dg/guality/guality.exp index 9a17850..a07a628 100644 --- a/gcc/testsuite/g++.dg/guality/guality.exp +++ b/gcc/testsuite/g++.dg/guality/guality.exp @@ -1,5 +1,8 @@ # This harness is for tests that should be run at all optimisation levels. +# Disable everywhere. These tests are very flaky. +return + load_lib g++-dg.exp load_lib gcc-gdb-test.exp diff --git a/gcc/testsuite/gcc.dg/guality/guality.exp b/gcc/testsuite/gcc.dg/guality/guality.exp index 49e2ac5..39bf4e3 100644 --- a/gcc/testsuite/gcc.dg/guality/guality.exp +++ b/gcc/testsuite/gcc.dg/guality/guality.exp @@ -1,5 +1,8 @@ # This harness is for tests that should be run at all optimisation levels. +# Disable everywhere. These tests are very flaky. +return + load_lib gcc-dg.exp load_lib gcc-gdb-test.exp diff --git a/gcc/testsuite/gfortran.dg/guality/guality.exp b/gcc/testsuite/gfortran.dg/guality/guality.exp index 2444d8d..fdf899b 100644 --- a/gcc/testsuite/gfortran.dg/guality/guality.exp +++ b/gcc/testsuite/gfortran.dg/guality/guality.exp @@ -1,5 +1,8 @@ # This harness is for tests that should be run at all optimisation levels. +# Disable everywhere. These tests are very flaky. +return + load_lib gfortran-dg.exp load_lib gcc-gdb-test.exp -- This patch is available for review at http://codereview.appspot.com/4328047