On Wed, Apr 20, 2011 at 18:00, Jason Merrill <ja...@redhat.com> wrote: > On 04/12/2011 11:49 AM, Lawrence Crowl wrote: >> >> This patch is available for review at >> http://codereview.appspot.com/4378056 > > I tried to comment there, but it didn't seem to be working; looking at the > side-by-side diffs didn't show any changes, and double-clicking on a line in > the patch form didn't let me add a comment.
If you are logged in and click on the file (not the side-by-side), you can double-click on the patch hunk you want to comment on (you'll need to cut-n-paste some context due to http://code.google.com/p/rietveld/issues/detail?id=291&can=4). Now, for some reason I never could quite grasp, some of Lawrence's patches were uploaded in such a way that both the base file and the patched file are the same. That's why the side-by-side view is not working. Subsequent patches from Lawrence did not have that problem. So, whatever it was, it got fixed (but I'm not sure what fixed it). Diego.