-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 On 04/21/11 11:43, Xinliang David Li wrote:
> > There are three different kind of uninit warnings: > > 1) definitely uninitialized, and the use the variable dominates the > exit -- this is the must be used uninitialized case > 2) definitely uninitialized, but the use may not be executed at runtime; > 3) Only initialized in some paths from entry to the use (the use may > or may not be executed). > > Currently 2) and 3) uses the same warning message, which may be misleading. > > The proposed new option only controls 3). It's certainly possible to have an uninitialized use dominating an exit which can never be executed (think infinite loop which can't be detected at compile time. I bring these issues up primarily to get us thinking about how better to describe the scenarios where we warn in our documentation. I don't want to hold up real improvements. > >> No, the patch does not change the default behavior of -Wuninitialized >> wihch will turn on -Wmaybe-uninitialized as well. The only useful >> scenarios for the new option are: OK. I must have misread something. Given the fact that your patch isn't changing the -Wuninitialized behaviour, then let's go ahead with your patch. Jeff -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org/ iQEcBAEBAgAGBQJNtem+AAoJEBRtltQi2kC7f54IALq8+i2dtRw2z/r6rKYX6+JD u0eraT4+U5q58ZQQZeU05eBKv4P3Soq14z4/RuuM7dTuU44fqOKz4IrvAxUmnm9f pdQy4OWHs1/vMR/04JdYy2IjDNbx9tRADioD4VvgrvfBSYHhZvLTJHg5ggAmk2eS S1Dd1tnKrfn/h0Bz3wqwNDblAQT2TzUvYRcBEq+iTzBQWbrkCCKLr+rWIxEeCDGn 679hkhiFeUYcoFSvYIXc54YCYWCjWsdj5n3Fg9ex7IWGblvfjPejUfq//Xr2wq0J jlDfuo3mDoDEgLxQ94RRMeHYf7kwCRhwiYqul/U2Fg7UOHlci2aWKpCfHEdY5VI= =no9V -----END PGP SIGNATURE-----
