On Wed, Apr 27, 2011 at 6:30 PM, Gabriel Dos Reis <g...@cs.tamu.edu> wrote: > > Richard, > > Your recent patch broke --enable-build-with-cxx because internal-fn.h > was using good 'ol C-style name lookup trick that behaves badly with > C++ linkage rules. Fixed thusly. Applied as obvious.
Can you explain some more? Does it have do with the fact those functions are static? If so I think we should move away from static functions for compiling with C++ and move to using anonymous namespaces. Thanks, Andrew Pinski