Tracer is not turned on by default for non-FDO case -- Sharad's change simply turns it off by default for all cases.
David On Thu, Apr 28, 2011 at 4:38 PM, Richard Guenther <richard.guent...@gmail.com> wrote: > On Fri, Apr 29, 2011 at 1:34 AM, Xinliang David Li <davi...@google.com> wrote: >> Sharad can provide some some performance data -- we have seen up to 2% >> degradation to with tracer turned on for one of google's most >> important program. Perhaps Sharad can collect some SPEC numbers. >> >> I agree a better approach should be to fix the problem in tracer >> instead of turning it off in trunk. > > Esp. not turning it off for profile-use only where it should have the most > precise input. > > Richard. > >> David >> >> >> On Thu, Apr 28, 2011 at 4:23 PM, Richard Guenther >> <richard.guent...@gmail.com> wrote: >>> On Thu, Apr 28, 2011 at 8:53 PM, Diego Novillo <dnovi...@google.com> wrote: >>>> On Thu, Apr 28, 2011 at 14:51, Sharad Singhai <sing...@google.com> wrote: >>>>> This patch disables -ftracer for profile use. Okay for google/main? >>>> >>>> Could you elaborate on why doing this is beneficial? Are you >>>> proposing this for trunk as well? >>> >>> It indeed doesn't make sense to me at all. >>> >>> Richard. >>> >>>>> 2011-04-28 Sharad Singhai <sing...@google.com> >>>>> >>>>> Google Ref 40087 >>>>> * opts.c (common_handle_option): Disable -ftracer for profile use. >>>>> * doc/invoke.texi: Update doc that -ftracer is no longer enabled >>>>> for FDO. >>>> >>>> OK. >>>> >>>> >>>> Diego. >>>> >>> >> >
