> You don't mean the prototype, do you? IMHO the char * should still be > changed to const char * to adhere to POSIX.
So far, it's served as a good tool for detecting when libiberty's configure isn't doing its job :-) At this point, we should avoid "fixing" it until the newlib/configure issue is fixed, otherwise the problem will get hidden away again. If, after that, you want to posixify libiberty some more, we'll worry about it then.
