On 2011/5/6 05:57 PM, Paolo Bonzini wrote: > On 04/22/2011 05:21 PM, Chung-Lin Tang wrote: >> Also, instead of testing for XEXP(SET_SRC(PATTERN(i3)),1) == const0_rtx >> at the top, it now allows CONST_INT_P(XEXP(SET_SRC(PATTERN(i3)),1)), >> tries to adjust it by simplify_compare_const() from the last patch, and >> then tests if op1 == const0_rtx. This is a small improvement in some >> cases. > > I'm not sure why it doesn't allow both? > > Paolo
Hi Paolo, I'm not sure I understand your meaning of 'both', but before this patch, it only tested for == const0_rtx, without any attempt of other cases. Now it tests CONST_INT_P(XEXP(SET_SRC(PATTERN(i3)),1)), attempts a simplification which may change a non-zero constant to const0_rtx, then test for const0_rtx. Supposedly, the new code should be strictly more general. Thanks, Chung-Lin
