Ping. David
On Fri, May 20, 2011 at 9:06 AM, Xinliang David Li <davi...@google.com> wrote: > Ok to check in this one? > > Thanks, > > David > > On Wed, May 18, 2011 at 12:30 PM, Joseph S. Myers > <jos...@codesourcery.com> wrote: >> On Wed, 18 May 2011, David Li wrote: >> >>> + error ("Unrecognized option %s", is_enable ? "-fenable" : >>> "-fdisable"); >> >>> + error ("Unknown pass %s specified in %s", >>> + phase_name, >>> + is_enable ? "-fenable" : "-fdisable"); >> >> Follow GNU Coding Standards for diagnostics (start with lowercase letter). >> >>> + inform (UNKNOWN_LOCATION, "%s pass %s for functions in the range of >>> [%u, %u]\n", >>> + is_enable? "Enable":"Disable", phase_name, new_range->start, >>> new_range->last); >> >> Use separate calls to inform for the enable and disable cases, so that >> full sentences can be extracted for translation. >> >>> + error ("Invalid range %s in option %s", >>> + one_range, >>> + is_enable ? "-fenable" : "-fdisable"); >> >> GNU Coding Standards. >> >>> + error ("Invalid range %s in option %s", >> >> Likewise. >> >>> + inform (UNKNOWN_LOCATION, "%s pass %s for functions in the range >>> of [%u, %u]\n", >>> + is_enable? "Enable":"Disable", phase_name, >>> new_range->start, new_range->last); >> >> Again needs GCS and i18n fixes. >> >> -- >> Joseph S. Myers >> jos...@codesourcery.com >> >