On Wed, May 25, 2011 at 12:00 AM, Eric Botcazou <ebotca...@adacore.com> wrote: >> Yes, I mean when -fstack-usage is enabled. Thus, make >> -fstack-usage -Wframe-larger-than behave the same as >> -fstack-usage -Wstack-usage. Or do you say that -Wstack-usage >> doesn't require -fstack-usage? > > Yes, -Wstack-usage doesn't require -fstack-usage. > >> If it doesn't then I hope -Wstack-usage does not have effects on code >> generation? > > Neither -fstack-usage nor -Wstack-usage has any effect on code generation. > The former generates a .su file and the latter issues a warning. > >> And if not then why can't -Wframe-larger-than just be more precise on some >> targets? > > -Wframe-larger-than is documented to work on any targets and to be imprecise. > So we would need to list the targets for which it is precise (or the targets > for which it isn't precise) and maintain it. By contrast, if -Wstack-usage > returns something, then the answer is always precise. Moreover I think that > the common name is a big advantage.
Thanks for explaining. The patch is ok. Thanks, Richard. > -- > Eric Botcazou >
