On 05/25/2011 01:45 PM, Hans-Peter Nilsson wrote:
> On Wed, 25 May 2011, Bernd Schmidt wrote:
> 
>> I'm not sure where you're looking for added documentation for this
>> patch.
> 
> I guess no surprise that'd be md.texi node Defining Attributes,

That covers define_attr, not set_attr, so it seems inappropriate.

> or an updated example in node Attr Example since the
> documentation for "default" basically just refers to it.  Or
> perhaps better node Expressions where (attr x) is documented,
> since it says it's mostly useful for numeric attributes and not
> so for non-numeric attributes.  Perhaps add after that sentence
> "It can also be used to yield the value of another attribute,
> useful to e.g. set the value of the current attribute if they
> share a domain".  You can probably find a better wording. :)

To be honest I can't think of anything reasonable to add there. The
documentation already says you can use (attr "...") to return the value
of another attribute... all my patch did was make that actually work in
some situations.


Bernd

Reply via email to