> On Wed, Jun 1, 2011 at 2:03 AM, Xinliang David Li <davi...@google.com> wrote: > > Please discard the previous one. This is the right one: > > See also Honzas comments (on the wrong patch presumably ;)). > > + if (node) > + fprintf (dump_file, "\n;; Function %s (%s, funcdef_no=%d, > decl_uid = %d, cgraph_uid=%d)", > + dname, aname, fun->funcdef_no, DECL_UID(fdecl), node->uid); > + else > + fprintf (dump_file, "\n;; Function %s (%s, funcdef_no=%d, decl_uid = > %d)", > + dname, aname, fun->funcdef_no, DECL_UID(fdecl)); > + > + fprintf (dump_file, "%s\n\n", > + node->frequency == NODE_FREQUENCY_HOT > > you also need to check for node == NULL here. > > Ok with this (and honzas suggested change for not passing struct > function *). Also I still think the function funcdef_no is quite redundant UID. For debugging profiling I would go for cgraph_uid instead. It has also the advantage of being available at WPA stage. But I have nothing against printing it here.
Honza
