On Jun 9, 2011, at 12:14 AM, Rainer Orth wrote: > Mike Stump <mikest...@comcast.net> writes: >> On Apr 5, 2011, at 1:56 AM, Rainer Orth wrote: >>> * lto.c (promote_var): Only set VISIBILITY_HIDDEN if >>> HAVE_GAS_HIDDEN. >> >> This looks wrong, there are more things that have visibility than those >> things that use GAS and have .hidden. Darwin I think is one of them. ? >> cygming.h seems to be another. > > Now that Darwin has been switched to define HAVE_GAS_HIDDEN, is the > lto.c part ok?
I don't have any lto specific objections related to this.