Re: FORBIDDEN_INC_DEC_CLASSES in ira-costs.c

[Vladimir Makarov]

On 11-06-10 8:35 AM, Hans-Peter Nilsson wrote:

On Thu, 9 Jun 2011, Hans-Peter Nilsson wrote:

        * ira-costs.c: Remove #ifdefs on dead FORBIDDEN_INC_DEC_CLASSES.
        Adjust comments.
        * system.h (FORBIDDEN_INC_DEC_CLASSES): Poison.
Index: ira-costs.c
===================================================================
--- ira-costs.c (revision 174878)
+++ ira-costs.c (working copy)

Oops; I spotted a missing comment update.
Please replace these hunks:

@@ -1685,9 +1651,6 @@ find_costs_and_classes (FILE *dump_file)
              /* Ignore classes that are too small for this operand or
                 invalid for an operand that was auto-incremented.  */
              if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
-                 || (inc_dec_p&&  forbidden_inc_dec_class[rclass])
-#endif
  #ifdef CANNOT_CHANGE_MODE_CLASS
                  || invalid_mode_change_p (i, (enum reg_class) rclass)
  #endif
@@ -1764,9 +1727,6 @@ find_costs_and_classes (FILE *dump_file)
                         operand or invalid for an operand that was
                         auto-incremented.  */
                      if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
-                         || (inc_dec_p&&  forbidden_inc_dec_class[rclass])
-#endif
  #ifdef CANNOT_CHANGE_MODE_CLASS
                          || invalid_mode_change_p (i, (enum reg_class) rclass)
  #endif

with these:


@@ -1682,12 +1648,9 @@ find_costs_and_classes (FILE *dump_file)
          for (k = 0; k<  cost_classes_ptr->num; k++)
            {
              rclass = cost_classes[k];
-             /* Ignore classes that are too small for this operand or
-                invalid for an operand that was auto-incremented.  */
+             /* Ignore classes that are too small or invalid for this
+                operand.  */
              if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
-                 || (inc_dec_p&&  forbidden_inc_dec_class[rclass])
-#endif
  #ifdef CANNOT_CHANGE_MODE_CLASS
                  || invalid_mode_change_p (i, (enum reg_class) rclass)
  #endif
@@ -1760,13 +1723,9 @@ find_costs_and_classes (FILE *dump_file)
                      rclass = cost_classes[k];
                      if (! ira_class_subset_p[rclass][regno_aclass[i]])
                        continue;
-                     /* Ignore classes that are too small for this
-                        operand or invalid for an operand that was
-                        auto-incremented.  */
+                     /* Ignore classes that are too small or invalid
+                        for this operand.  */
                      if (! contains_reg_of_mode[rclass][PSEUDO_REGNO_MODE (i)]
-#ifdef FORBIDDEN_INC_DEC_CLASSES
-                         || (inc_dec_p&&  forbidden_inc_dec_class[rclass])
-#endif
  #ifdef CANNOT_CHANGE_MODE_CLASS
                          || invalid_mode_change_p (i, (enum reg_class) rclass)
  #endif

brgds, H-P

The patch is ok with these changes.   Thanks for the patch.