On 06/25/2011 04:56 PM, Mike Stump wrote: > On Jun 15, 2011, at 5:57 PM, Janis Johnson wrote: >> The bug was in my attempt to run the tests with other -mfpu values, so >> I'm very glad you caught that. I tried again, getting rid of the neon >> requirement along the way, and found a way to run the VFP fp16 tests >> with any of the fp16 values that Joseph listed. >> >> This patch renames *arm_neon_fp16* to *arm_fp16* and skips tests if the >> multilib does not support arm32, includes -mfpu that is not fp16, or >> includes -mfloat-abi=soft. If the multilib uses -mfpu= with an fp16 >> value then that is used, otherwise -mfpu=vfpv4 is used. Added flags >> include -mfloat-abi=softfp in case the default is "soft". > >> OK for trunk, and for 4.6 a few days later? > > Ok. Ok for 4.6. For 4.6, as also please ensure that the RMs don't have the > branch locked down.
I'm waiting until after the 4.6.1 release to move anything more to that branch. > General comment, I'm happy to have the front-end, target and library > maintainers review and approve the normal additions to the .exp files > to support testing their bits. Yep! Janis
