On 06/24/2011 02:59 AM, Richard Earnshaw wrote:
> On 18/06/11 20:02, Richard Henderson wrote:
>> I couldn't find anything terribly tricky about the conversion.
>>
>> The existing push_mult pattern would service thumb1 with just
>> a tweak or two to the memory predicate and the length.
>>
>> The existing emit_multi_reg_push wasn't set up to handle a
>> complete switch of registers for unwind info. I thought about
>> trying to merge them, but thought chickened out.
>>
>> I havn't cleaned out the code that is now dead in thumb_pushpop.
>> I'd been thinking about maybe converting epilogues completely
>> to rtl as well, which would allow the function to be deleted
>> completely, rather than incrementally.
>>
>> I'm unsure what testing should be applied. I'm currently doing
>> arm-elf, which does at least have a thumb1 multilib, and uses
>> newlib so I don't have to fiddle with setting up a full native
>> cross environment. What else should be done? arm-eabi?
>>
>
> Testing this on arm-eabi is essential since this may affect C++ unwind
> table generation (I can't see any obvious problems, but you never know).
>
I've now tested the patch with both arm-elf and arm-eabi with
RUNTESTFLAGS='--target_board=arm-sim{-mthumb}' with no regressions.
Ok to install?
r~
