On 28 Jun 2011, at 18:01, Iain Sandoe wrote:
On 28 Jun 2011, at 17:47, Rainer Orth wrote:
objc.dg/torture/forward-1.m now seems to XPASS everywhere, creating
an
annoying amount of testsuite noise. Dominique provided the following
patch in PR libobjc/Bug 36610.
Tested with the appropriate runtest invocations on i386-pc-
solaris2.10
(both multilibs), sparc-sun-solaris2.10 (both multilibs),
alpha-dec-osf5.1b, mips-sgi-irix6.5 (both multilibs),
powerpc-apple-darwin9.8.0 (32-bit only).
Ok for mainline?
Thanks.
Rainer
2011-06-28 Dominique d'Humieres <domi...@lps.ens.fr>
* objc.dg/torture/forward-1.m: Remove dg-xfail-run-if, dg-skip-if.
Index: gcc/testsuite/objc.dg/torture/forward-1.m
===================================================================
--- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175589)
+++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
@@ -1,7 +1,5 @@
/* { dg-do run } */
/* See if -forward:: is able to work. */
-/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } &&
ilp32 } } { "-fgnu-runtime" } { "" } } */
-/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* &&
{ lp64 } } { "-fnext-runtime" } { "" } } */
actually, looking at this, it should likely read (untested):
/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* &&
{ lp64 && { ! objc2 } } } { "-fnext-runtime" } { "" } } */
and should stay in place to protect the test-cases for m64 on *-*-
darwin8*
(not that there's ever likely to be an m64 objc2 on darwin 8.. but)
Just FTR, this works for me on powerpc-apple-darwin9
Iain
Index: gcc/testsuite/objc.dg/torture/forward-1.m
===================================================================
--- gcc/testsuite/objc.dg/torture/forward-1.m (revision 175578)
+++ gcc/testsuite/objc.dg/torture/forward-1.m (working copy)
@@ -1,7 +1,6 @@
/* { dg-do run } */
/* See if -forward:: is able to work. */
-/* { dg-xfail-run-if "PR36610" { ! { { i?86-*-* x86_64-*-* } &&
ilp32 } } { "-fgnu-runtime" } { "" } } */
-/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin* &&
{ lp64 } } { "-fnext-runtime" } { "" } } */
+/* { dg-skip-if "Needs OBJC2 Implementation" { *-*-darwin8* && { lp64
&& { ! objc2 } } } { "-fnext-runtime" } { "" } } */
#include <stdio.h>
#include <stdlib.h>
