Hi Andre, > Now, the patch was not intended to solve 61337. Although I have looked into > the > pseudo code generated for 61337, I couldn't figure easily what is going on > there. In my impression, this is something from incorrectly computed bounds to > an integer(8),pointer integer(4),pointer mix up. Therefore no patch for that > from my side currently.
I think that this a completely different issue from that addressed by your patch and I don't think you should tackle anything non-character-related in your patch. > Nevertheless, do I hope that some reviewer finds a minute to look at the patch > for pr60255. I had a look over the patch, and it looks mostly fine to me. A few remarks: 1) There are still two TODO markers in the patch. It might be a good idea to take care of them before committing the patch. In particular for the first one (adding the initializer in gfc_build_class_symbol) it would be good to understand where those problems come from. For the second one (in gfc_conv_expr), I don't directly see how it's related to deferred char-len. Why is this change needed? 2) You're making a lot of changes to 'trans_associate_var', but I don't see any ASSOCIATE statements covered in your test case. Can you add more test cases which cover this code? 3) The function 'gfc_get_len_component' that you're introducing is only called in a single place. Do you expect this to be useful in other places in the future, or could one remove the function and insert the code inline? 4) You're adding a prototype for a function 'gfc_assign_charlen_to_unlimited_poly' in gfortran.h which never gets implemented. 5) The second hunk in find_intrinsic_vtab is a whitespace-only change which should not occur at all AFAICS. In any case, thanks for working on this! Cheers, Janus > On Tue, 30 Dec 2014 16:35:48 +0100 > Dominique d'Humières <domi...@lps.ens.fr> wrote: > >> The new patch fixes the ICEs, but still emit the wrong codes reported in >> pr61337. >> >> Thanks and Happy New Year to all, >> >> Dominique >> >> > Le 30 déc. 2014 à 14:39, Andre Vehreschild <ve...@gmx.de> a écrit : >> > >> > Hi Dominique, >> > >> > thanks for pointing that out. That was caused by a flaw in the current >> > patch. In the attached version this is fixed now. >> > >> > Bootstraps and regtests ok on x86_64-linux-gnu. >> > >> > Regards, >> > Andre >> > >> > On Mon, 29 Dec 2014 16:32:27 +0100 >> > Dominique d'Humières <domi...@lps.ens.fr> wrote: >> > >> >> For the record, compiling the tests in pr61337 with the patch applied on >> >> top of r219099 gives ICEs: >> >> >> >> use array_list >> >> 1 >> >> internal compiler error: in gfc_advance_chain, at fortran/trans.c:58 >> >> >> >> Since this replaces some wrong-code generation by some ICEs, I don’t think >> >> this should delay the fix of pr60255. >> >> >> >> Cheers, >> >> >> >> Dominique >> > > > -- > Andre Vehreschild * Kreuzherrenstr. 8 * 52062 Aachen > Tel.: +49 241 9291018 * Email: ve...@gmx.de
