On 9 January 2015 at 11:26, Martin Liška <mli...@suse.cz> wrote:
> On 01/09/2015 06:21 AM, Jeff Law wrote:
>>
>> On 01/07/15 04:38, Martin Liška wrote:
>>>
>>> Hello.
>>>
>>> Following patch adds support for target and optimization nodes
>>> comparison, which is
>>> based on Honza's newly added infrastructure.
>>>
>>> Apart from that, there's a small hunk that corrects formatting and
>>> removes unnecessary
>>> call to a comparison function.
>>>
>>> Hope it can be applied as one patch.
>>>
>>> Tested on x86_64-linux-pc without any new regression introduction.
>>>
>>> Ready for trunk?
>>>
>>> Thank you,
>>> Martin
>>>
>>> 0001-IPA-ICF-target-and-optimization-flags-comparison.patch
>>>
>>>
>>> From 393eaa47c8aef9a91a1c635016f23ca2f5aa25e4 Mon Sep 17 00:00:00 2001
>>> From: mliska<mli...@suse.cz>
>>> Date: Tue, 6 Jan 2015 15:06:18 +0100
>>> Subject: [PATCH] IPA ICF: target and optimization flags comparison.
>>>
>>> gcc/ChangeLog:
>>>
>>> 2015-01-06 Martin Liska<mli...@suse.cz>
>>>
>>> * cgraphunit.c (cgraph_node::create_wrapper): Fix level of
>>> indentation.
>>> * ipa-icf.c (sem_function::equals_private): Add support for target
>>> and
>>> (sem_item_optimizer::merge_classes): Remove redundant function
>>> comparison.
>>> optimization flags comparison.
>>> * tree.h (target_opts_for_fn): New function.
>>
>> Looks like the changelog is a bit goof'd with lines intermixed.
>>
>> Patch itself is good for the trunk. It'd be nice if you could add a
>> testcase as well.
>>
>> Jeff
>
>
> Hi.
>
> You are right, I forgot to delete a line in Changelog.
> Attachment contains final version with a new test case I'm going to install.
>
Hi,
It looks like this patch broke GCC builds for ARM and AArch64 targets at least.
I see failures builds pr-support.o and unwind-arm.o:
0x10bb077 tree_check
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree.h:2778
0x10bb077 target_opts_for_fn
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/tree.h:4681
0x10bb077 ipa_icf::sem_function::equals_private(ipa_icf::sem_item*,
hash_map<symtab_node*, ipa_icf::sem_item*, default_hashmap_traits>&)
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/ipa-icf.c:431
0x10bbd27 ipa_icf::sem_function::equals(ipa_icf::sem_item*,
hash_map<symtab_node*, ipa_icf::sem_item*, default_hashmap_traits>&)
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/ipa-icf.c:386
0x10ba63a ipa_icf::sem_item_optimizer::subdivide_classes_by_equality(bool)
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/ipa-icf.c:1893
0x10bcd86 ipa_icf::sem_item_optimizer::execute()
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/ipa-icf.c:1712
0x10bce11 ipa_icf_driver
/tmp/2239141_1.tmpdir/aci-gcc-fsf/sources/gcc-fsf/gccsrc/gcc/ipa-icf.c:2441
(for target arm-none-eabi)
> Thanks,
> Martin
