On 15 Jan 09:40, Mike Stump wrote:
> On Jan 15, 2015, at 8:14 AM, Ilya Verbin <iver...@gmail.com> wrote:
> > The problem is that gcc-dg.exp calls check_effective_target_lto, which calls
> > libatomic_target_compile.  Therefore gcc-dg.exp should be loaded only after 
> > the
> > definition of libatomic_target_compile.
> 
> > However, a similar exp file in other tree (libitm/testsuite/lib/libitm.exp)
> > doesn't contain any explicit 'load_gcc_lib gcc-dg.exp' at all, but it loads
> > gcc-dg.exp implicitly.  So I'm not sure whether this patch is correct.
> 
> So, can you try the itm version of this?  If that works, Ok.

If I just remove 'load_gcc_lib gcc-dg.exp' from libatomic.exp, like this is done
in libitm.exp, it will not work:

$ make check-target-libatomic
...
ERROR: (DejaGnu) proc "gcc-dg-test-1 libatomic_target_compile 
../../../../gcc/libatomic/testsuite/libatomic.c/atomic-compare-exchange-1.c run 
{ -g}" does not exist.

Note that gcc-dg-test-1 is defined in gcc-dg.exp, so it's somehow automatically
loaded for libitm and other libs, but non loaded for libatomic.

  -- Ilya

Reply via email to