On 16 January 2015 at 16:23, Christophe Lyon <christophe.l...@linaro.org> wrote: > On 16 January 2015 at 15:09, Tejas Belagod <tejas.bela...@arm.com> wrote: >> On 13/01/15 15:18, Christophe Lyon wrote: >>> >>> * gcc.target/aarch64/advsimd-intrinsics/vld1_lane.c: New file.
>> Hmm.. again, I don't see vld1<q>_lane_f64? > > Same answer: unless I am mistaken it isn't supported on armv7, and > indeed the tests need to be expanded. > >>> +#ifndef __CC_ARM >>> + /* Check runtime assertions. With RVCT, the check is performed at >>> + compile-time */ >>> + // TEST_VLD1_LANE(, int, s, 64, 1, 1); >>> +#endif >>> + >> >> Does this belong in this patch? > Good catch! > The original testsuite uses RVCT features not present in GCC, and I > forgot to remove this chunk. > >> Otherwise, it looks good to me(I cannot approve though). OK with that hunk dropped, provided no new fails on aarch64[_be] and arm. /Marcus
