On Thu, Jan 22, 2015 at 3:44 PM, Matthias Klose <d...@ubuntu.com> wrote:
>
> However for the libbacktrace and the libsanitizer builds, the
> AM_ENABLE_MULTILIB
> macro is included way too late. Scan the generated configure file for
> "cross_compiling" and see that the above snippet is added after the failing
> checks. The fix seems to be simple, just move the AM_ENABLE_MULTILIB macro up
> so
> that the "cross_compiling" value is corrected before it is tested. This is
> what
> the patch is doing.
>
> However ... for every runtime library there is still something wrong, at least
> one linker check in the generated configure is done before the expansion of
> the
> AM_ENABLE_MULTILIB macro. I'm not trying to fix that with this patch ...
> autoconf offers a AC_REQUIRE macro, so AM_ENABLE_MULTILIB should add one to
> ensure that this macros is always expanded before the first check for
> "cross_compiling", but I'm not sure which one.
>
> Small patch, but took me some time to find out :-/
>
> This patch should go to trunk and all active branches. Ok to check in?
The libbacktrace library is unusual because we build it for both the
host and the target. When building for the host, we do not want to
multilib it--that would make no sense. You've moved the
AM_ENABLE_MULTILIB out of the test -n "${with_target_subdir}"; don't
do that.
It's fine with me if you move AM_ENABLE_MULTILIB earlier as long as
you keep the test.
Probably a build maintainer should take a look at this patch.
Ian
