Hi Venkat,

> I committed the patch with the change log corrections you said.
>
> https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=220034

unfortunately, it broke bootstrap for an i686-unknown-linux-gnu
--enable-targets=all build: the 64-bit libtsan.so fails to link:

.libs/tsan_interface_atomic.o: In function 
`__tsan::TraceAddEvent(__tsan::ThreadState*, __tsan::FastState, 
__tsan::EventType, unsigned long long)':
/vol/gcc/src/hg/trunk/local/libsanitizer/tsan/tsan_rtl.h:715: undefined 
reference to `__tsan_trace_switch_thunk'
[...
.libs/tsan_rtl_mutex.o:/vol/gcc/src/hg/trunk/local/libsanitizer/tsan/tsan_rtl.h:715:
 more undefined references to `__tsan_trace_switch_thunk' follow
/vol/gcc/bin/i686/gld-2.24: .libs/libtsan.so.0.0.0: hidden symbol 
`__tsan_report_race_thunk' isn't defined
/vol/gcc/bin/i686/gld-2.24: final link failed: Bad valu
collect2: error: ld returned 1 exit status
make[6]: *** [libtsan.la] Error 1

The problem is that libsanitizer/configure.ac checks for target
x86_64-*-linux-*, which is wrong in this case.  I believe that you need
something like libgcc's host_address instead and then check for either
x86_64-*-linux-* or i?86-*-linux-* and host_address=64.

        Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University

Reply via email to