On 01/29/2015 01:10 AM, Iain Sandoe wrote: > > On 28 Jan 2015, at 18:16, Richard Henderson wrote: > >> On 01/28/2015 10:10 AM, Dominique d'Humières wrote: >>>> I can't think of any reason they shouldn't work. Were they not running >>>> before, >>>> or did something else change? >>> >>> AFAIU the commit, the tests were not run on x86_64-*-*, so the tests and >>> the corresponding failures are new. >> >> Well, the commit fixed the fact that they weren't running on x86_64 for the >> -m32 multilib. If you had built a i686-darwin before the commit, the tests >> should have already been running (and, presumably, failing). > > I don't think (To Be Confirmed) this mode has ever been tested on Darwin in > previous incarnations of libffi. > (i.e darwin + windows call markers) ISTM that the first occassion was > following your commit 12th Jan.
Oh, duh. I must have been asleep yesterday evening or something. Of course these tests won't work on darwin. At least not until it can actually use the modern x86/ffi.c instead of the old code that got copied in to x86/darwin_c.c > Well, somewhat confusingly "x86/darwin_c.c" is shared between darwin and the > various Windows 32 bit implementations. It's not shared with anything. It's a copy of the old x86/ffi.c prior to the merge from upstream. r~
