On 17/11/14 17:03, pins...@gmail.com wrote: > > > > >> On Nov 17, 2014, at 8:59 AM, Ramana Radhakrishnan >> <ramana....@googlemail.com> wrote: >> >>> On Mon, Nov 17, 2014 at 2:48 PM, Kyrill Tkachov <kyrylo.tkac...@arm.com> >>> wrote: >>> Hi all, >>> >>> Some configurations of Cortex-A53 and Cortex-A57 don't ship with crypto, >>> so enabling it by default for -mcpu=cortex-a53 and cortex-a57 is >>> inappropriate. >>> >>> Tested aarch64-none-elf. Reminder that at the moment all the crypto >>> extension does is enable the use of the ACLE crypto intrinsics in arm_neon.h >>> >>> Ok for trunk? >> >> I can't ok this but ... >> >> Since we've changed behaviour from 4.9 I think it warrants an entry in >> changes.html for 5.0 > > ThunderX should also disable crypto too by default. I will submit a patch for > that soon too. >
You appear to have not yet done so... BTW, you can consider such a change pre-approved. R. > Thanks, > Andrew > >> >> Ramana >> >>> >>> Thanks, >>> Kyrill >>> >>> 2014-11-17 Kyrylo Tkachov <kyrylo.tkac...@arm.com> >>> >>> * config/aarch64/aarch64-cores.def (cortex-a53): Remove >>> AARCH64_FL_CRYPTO from feature flags. >>> (cortex-a57): Likewise. >>> (cortex-a57.cortex-a53): Likewise. >