On 8 April 2015 at 21:45, Diego Novillo <dnovi...@google.com> wrote:
> On Wed, Apr 8, 2015 at 3:36 PM, Bernhard Reutner-Fischer
> <rep.dot....@gmail.com> wrote:
>> contrib/ChangeLog:
>>
>> 2015-04-08  Bernhard Reutner-Fischer  <al...@gcc.gnu.org>
>>
>>         * mklog ($name, $addr): Fallback to env author settings.
>
> This looks fine, but note that I no longer have approval rights for

yuck. I remember now, what a pity.

> patches. Code in contrib/ has looser requirements, and the patch is
> clearly harmless. I would just add documentation on the GIT_AUTHOR_*
> environment variables at the top of the script.

I'll document them, thanks!

Reply via email to